Add the preferKeepingExistingSuppression extension property to shunt removeUnused mode for non-standard checks#279
Open
kelvinou01 wants to merge 1 commit into
Open
Conversation
Generate changelog in
|
SuppressibleErrorProne:PreferKeepingExistingSuppression extension option to shunt removeUnused mode for non-standard checksPreferKeepingExistingSuppression extension option to shunt removeUnused mode for non-standard checks
PreferKeepingExistingSuppression extension option to shunt removeUnused mode for non-standard checkspreferKeepingExistingSuppression extension property to shunt removeUnused mode for non-standard checks
✅ Successfully generated changelog entry!Need to regenerate?Simply interact with the changelog bot comment again to regenerate these entries. 📋Changelog Preview✨ Features
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
FLUP to #278
Our mental model of a BugChecker is
SuppressibleTreePathScanner)Some checkers break this
@DoNotLogand@Unsafe. However, these human-added suppressions are vetted and deliberate. The autofix downgrades the log-safety of the affected methods, which is undesireableAfter this PR
Add the
SuppressibleErrorProne:PreferKeepingExistingSuppressionoption, so removeUnused mode will shunt==COMMIT_MSG==
Add the
preferKeepingExistingSuppressionextension option to shunt removeUnused mode for non-standard checks==COMMIT_MSG==
Possible downsides?
If we want to be extra safe, we can make
removeUnusedonly remove rollout suppressions. This should be a small code change.I am leaning towards preferring autofixes as the default. We should roll this out with a background excavator to discover more rogue/undesireable fixes before integrating this into our upgrade infrastructure.